Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Intel" from the phrase "Intel FDO" #514

Closed
wants to merge 1 commit into from

Conversation

Piyush-Deshmukh
Copy link

@Piyush-Deshmukh Piyush-Deshmukh commented Aug 3, 2023

Description

Removed "Intel" from the phrase "Intel FDO" as the FDO project has requested that we change it to read merely "FDO" instead.

Fixes #513

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

Copy link
Member

@johnwalicki johnwalicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct technique to fix this issue is to make edits in the FDO-support repo. There is a CopyDocs GHA that will copy the markdown files here.

FWIW, the incorrectly placed docs/fdo/*.md files should be deleted. The live files are in docs/fdo/docs dir (via the GHA)

@joewxboy
Copy link
Member

@Piyush-Deshmukh Could you please remove the three changed files under the /fdo folder? Those need to be changed in the "FDO-Support" repo instead (which I just did).

The other files you've changed are fine, thanks.

@joewxboy
Copy link
Member

This work has been completed elsewhere, closing.

@joewxboy joewxboy closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug🐛: Remove "Intel" from the phrase "Intel FDO"
3 participants