Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tools, data and data-dependent tests/benches in packages #34

Closed
behnam opened this issue Jul 14, 2017 · 2 comments · Fixed by #42
Closed

Exclude tools, data and data-dependent tests/benches in packages #34

behnam opened this issue Jul 14, 2017 · 2 comments · Fixed by #42
Labels
A: packaging Packaging & Publishing
Milestone

Comments

@behnam
Copy link
Member

behnam commented Jul 14, 2017

We should use the Cargo exclude option to not publish data files to crates.io, as they are usually very large and almost of no use for 99.99% of the callers.

See servo/unicode-bidi#43 for report issue with publishing tests without data when published crate is being used in repackaging.

See also rust-lang/cargo#4268 for current limits of the exclude syntax, and the changes coming.

@behnam behnam assigned behnam and unassigned behnam Jul 14, 2017
@behnam behnam added the A: packaging Packaging & Publishing label Jul 14, 2017
@CAD97
Copy link
Collaborator

CAD97 commented Jul 16, 2017

Is there a way to dry-run cargo publish?

Without being able to test it, this might work (though since (I think) exclude doesn't get inherited it would have to be applied to all packages):

exclude = ["data/**/*", "src/**/tests/*conformance*.rs"]

@behnam
Copy link
Member Author

behnam commented Jul 17, 2017

cargo package creates the .crate file, which is what gets uploaded to crates.io, and downloaded later for consumption. The output is saved as target/package/<package-name>-<package-version>.crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: packaging Packaging & Publishing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants