Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contructor args in arguments.js #46

Closed
tmsdkeys opened this issue Mar 8, 2024 · 1 comment
Closed

Contructor args in arguments.js #46

tmsdkeys opened this issue Mar 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tmsdkeys
Copy link
Collaborator

tmsdkeys commented Mar 8, 2024

Right now, the arguments.js file enables devs to define constructor args arrays. It assumes that the application will alwyas either inherit UniversalChanIbcApp.sol or CustomChanIbcApp.sol and have dispatcher / middleware as their first contructor arg.

It lets devs define additonal args in arguments.js, while constructing a concatenated array with the dispatcher/mw when deploying, but arguably this is confusing.

Could look into different ways of ensuring constructor args are correctly added...

@tmsdkeys tmsdkeys added the enhancement New feature or request label Mar 8, 2024
@tmsdkeys
Copy link
Collaborator Author

Closing for now, I feel like this is working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant