Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: just command for verifying contracts #72

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Conversation

gr4yha7
Copy link
Contributor

@gr4yha7 gr4yha7 commented Apr 9, 2024

ref #17

Summary by CodeRabbit

  • New Features
    • Added a new task verify-contract to verify a smart contract on a chain using Hardhat.
    • Introduced logic to verify a smart contract on a specific chain using Hardhat.
  • Enhancements
    • Improved dependency checks and file existence validation before contract verification.
    • Added functionality to clean up temporary files post-verification.
    • Enhanced contract deployment configuration to support contractType parameter, optimizing configuration updates based on the network.

Copy link
Contributor

coderabbitai bot commented Apr 9, 2024

Walkthrough

This update enhances smart contract verification by introducing new tasks for verification using Hardhat, refining configuration handling for different networks, and streamlining the verification process. It ensures a robust and flexible workflow for verifying contracts on various blockchain networks.

Changes

Files Summary
Justfile Added a task for verifying smart contracts on a specific chain using Hardhat, enhancing the verification process. Removed Foundry-related verification task.
scripts/private/_deploy-config.js, scripts/private/_helpers.js Updated deployment configuration logic by adding a contractType parameter for network-specific updates.
scripts/verify.js Improved contract verification on specified networks using Hardhat, ensuring proper verification through network whitelisting and configuration-based deployment details.

🐇✨
In the land of code and byte,
Where smart contracts take their flight,
A rabbit worked through day and night,
To verify, with all its might.
"Let's toast," it said, "to contracts tight!"
🥕🚀🌌


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 830abd9 and d120176.
Files selected for processing (1)
  • scripts/private/_verify.js (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • scripts/private/_verify.js

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gr4yha7 gr4yha7 marked this pull request as draft April 9, 2024 11:11
@tmsdkeys
Copy link
Collaborator

Hey @gr4yha7 thank you for taking up this work! Did you intentionally put the PR in draft?

@gr4yha7
Copy link
Contributor Author

gr4yha7 commented Apr 10, 2024

Hey @gr4yha7 thank you for taking up this work! Did you intentionally put the PR in draft?

@tmsdkeys Yes, i have been trying to get the verification to work with Foundry. I guess i'll continue working on it in a separate PR.

@gr4yha7 gr4yha7 marked this pull request as ready for review April 10, 2024 21:53
@tmsdkeys
Copy link
Collaborator

Nice, that sounds good if it's possible through Hardhat for now. Reason I ask is because we'll be tagging some releases shortly and would like to have your contribution included :)
Will review shortly and like you said Foundry support can be added at later point!

Copy link
Collaborator

@tmsdkeys tmsdkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

One change I' suggest is to move verify.js to scripts/private and rename to _verify.js to keep consistency

Another change we could add is an extra just recipe, just deploy-verify SOURCE DESTINATION which is similar to deploy recipe but uses the verify script automatically after deployment to verify both contracts being deployed. I'll leave up to you if you want to implement this or if we should pick this up in a separate PR...

scripts/verify.js Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

scripts/private/_verify.js Show resolved Hide resolved
scripts/private/_verify.js Outdated Show resolved Hide resolved
scripts/private/_verify.js Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@tmsdkeys tmsdkeys merged commit b6535be into open-ibc:main Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants