-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: just command for verifying contracts #72
Conversation
WalkthroughThis update enhances smart contract verification by introducing new tasks for verification using Hardhat, refining configuration handling for different networks, and streamlining the verification process. It ensures a robust and flexible workflow for verifying contracts on various blockchain networks. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Hey @gr4yha7 thank you for taking up this work! Did you intentionally put the PR in draft? |
This reverts commit 0f9b324.
Nice, that sounds good if it's possible through Hardhat for now. Reason I ask is because we'll be tagging some releases shortly and would like to have your contribution included :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
One change I' suggest is to move verify.js to scripts/private and rename to _verify.js
to keep consistency
Another change we could add is an extra just recipe, just deploy-verify SOURCE DESTINATION
which is similar to deploy recipe but uses the verify script automatically after deployment to verify both contracts being deployed. I'll leave up to you if you want to implement this or if we should pick this up in a separate PR...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
ref #17
Summary by CodeRabbit
verify-contract
to verify a smart contract on a chain using Hardhat.contractType
parameter, optimizing configuration updates based on the network.