Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor solBus #1131

Closed
Mathadon opened this issue Apr 26, 2020 · 0 comments · Fixed by #1132
Closed

refactor solBus #1131

Mathadon opened this issue Apr 26, 2020 · 0 comments · Fixed by #1132
Milestone
Release 2.2

Comments

@Mathadon
Copy link
Member

solbus, which has many variables, currently passes through propsBus, which has many instances. This leads to a huge amount of connections and alias variables, which could create overhead at translations. This should be avoided by refactoring the code.
Mathadon added a commit that referenced this issue Apr 26, 2020
@Mathadon
revised how SolBus is connected in RadSolData
b4f422e 
this avoids translation overhead
see #1131
Mathadon added a commit that referenced this issue Apr 26, 2020
@Mathadon
changes to boundarywall for #1131
55ff6ea
Mathadon added a commit that referenced this issue Apr 26, 2020
@Mathadon
weabus paramaeters for #1131
84d9608
Mathadon added a commit that referenced this issue Apr 26, 2020
@Mathadon
updated IDEAS/Buildings/Components/Interfaces/DummyConnection.mo
1bdefd4 
for #1131
@Mathadon Mathadon mentioned this issue Apr 26, 2020
Merged
@Mathadon Mathadon added this to the Release 2.2 milestone Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.2
Development

Successfully merging a pull request may close this issue.

Issue1131 sol bus open-ideas/IDEAS
1 participant
@Mathadon