-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JModelica compliance #559
Comments
JModelica contains two bugs related to expandable connectors that prohibit the use of the IDEAS Buildings models. This issue and corresponding branch contains a workaround that makes the library (somewhat) compatible. |
When doing some simplifications IDEAS can be made to run on JModelica. E.g. the bus connectors can no longer be expandable and conservation of energy cannot conditionally be removed. The first option should not affect functionality/performance. The second would introduce additional equations that are currently disabled by default. |
@rubenbaetens @GlennReynders @damienpicard I'd like to propose the following changes for IDEAS 1.0:
any thoughts about this? |
code is on https://github.com/open-ideas/IDEAS/tree/issue559_JModelica and |
@Mathadon the linearization of IDEAS is actually not only useful for our MPC framework but also to be able to export the SSM to other platform such as Python or Matlab. I would definetly keep the framework making this possible in the master branch. However, if the problem is the expandable bus, we could replace the outer window bus by an array of busses whose size is defined by a parameter and, if necessary, connect the windows manually. |
fixed in #691 |
This issue is to report on the coverage of JModelica for the IDEAS library.
The text was updated successfully, but these errors were encountered: