Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JModelica compliance #559

Closed
Mathadon opened this issue Sep 2, 2016 · 6 comments
Closed

JModelica compliance #559

Mathadon opened this issue Sep 2, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@Mathadon
Copy link
Member

Mathadon commented Sep 2, 2016

This issue is to report on the coverage of JModelica for the IDEAS library.

Mathadon added a commit that referenced this issue Sep 2, 2016
@Mathadon
Copy link
Member Author

Mathadon commented Sep 2, 2016

JModelica contains two bugs related to expandable connectors that prohibit the use of the IDEAS Buildings models.
They are reported here
http://www.jmodelica.org/27735
http://www.jmodelica.org/27736

This issue and corresponding branch contains a workaround that makes the library (somewhat) compatible.

@Mathadon Mathadon self-assigned this Oct 12, 2016
@Mathadon
Copy link
Member Author

Mathadon commented Feb 11, 2017

When doing some simplifications IDEAS can be made to run on JModelica. E.g. the bus connectors can no longer be expandable and conservation of energy cannot conditionally be removed. The first option should not affect functionality/performance. The second would introduce additional equations that are currently disabled by default.
I could add this to the library for 1.0 on the master branch, or alternatively on a separate branch?

@Mathadon
Copy link
Member Author

@rubenbaetens @GlennReynders @damienpicard I'd like to propose the following changes for IDEAS 1.0:

  1. remove existing parameters, equations, busses, etc related to the linearisation approach that are not needed in JModelica and replace them by:
  2. add JModelica compatibility. This would require expandable busses to become normal busses and the computeConservationOfEnergy variables in the busses always need to be enabled. We could however introduce default zero values to remove any computation overhead.

sim.linearise, sim.linIntCon, etc would stay since they are required by both approaches.

any thoughts about this?

@Mathadon Mathadon added this to the Release 1.0 milestone Mar 22, 2017
@Mathadon Mathadon added feature and removed bug labels Mar 22, 2017
@Mathadon
Copy link
Member Author

code is on https://github.com/open-ideas/IDEAS/tree/issue559_JModelica and IDEAS.Buildings.Validation.BaseClasses.Structure.Bui600 is verified to work with JModelica rev. 9608 for simulations

@damienpicard
Copy link
Contributor

@Mathadon the linearization of IDEAS is actually not only useful for our MPC framework but also to be able to export the SSM to other platform such as Python or Matlab. I would definetly keep the framework making this possible in the master branch. However, if the problem is the expandable bus, we could replace the outer window bus by an array of busses whose size is defined by a parameter and, if necessary, connect the windows manually.

@Mathadon
Copy link
Member Author

fixed in #691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants