Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shading for non-windows #576

Closed
Mathadon opened this issue Oct 22, 2016 · 2 comments
Closed

Shading for non-windows #576

Mathadon opened this issue Oct 22, 2016 · 2 comments
Assignees
@Mathadon
Labels
feature
Milestone
Release 2

Comments

@Mathadon
Copy link
Member

Currently we do not consider shading on walls. This could be added, possibly with minimal effort?
@Mathadon Mathadon self-assigned this Oct 22, 2016
@Mathadon Mathadon added stale and removed feature labels Dec 8, 2016
Mathadon added a commit that referenced this issue May 29, 2018
@Mathadon
added building shade implementation for OuterWall
b573e2b 
see #576
@Mathadon Mathadon mentioned this issue May 29, 2018
Merged
@Mathadon
Copy link
Member Author

I added an implementation in #836. I only added the BuildingShade option since this is the most likely option to be used. In practice, things like an overhang sometimes also shade a wall. We could also make the shaType component replaceable such that users can redeclare the component if they have more specific needs?

@Mathadon Mathadon added feature and removed stale labels May 29, 2018
@Mathadon Mathadon added this to the Release 1.1 milestone May 29, 2018
Mathadon added a commit that referenced this issue May 29, 2018
@Mathadon
revised documentation and made shading replaceable in OuterWall
747163a 
see #576
@Mathadon
Copy link
Member Author

closed through #836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mathadon Mathadon

Labels
feature
Projects
None yet
Milestone
Release 2
Development

No branches or pull requests
1 participant
@Mathadon