Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unguarded implementation of azimuth angle computation #753

Closed
Mathadon opened this issue Oct 24, 2017 · 2 comments
Closed

Unguarded implementation of azimuth angle computation #753

Mathadon opened this issue Oct 24, 2017 · 2 comments
Assignees
@Mathadon
Labels
bug
Milestone
Release 2

Comments

@Mathadon
Copy link
Member

Currently azimuth angles are implemented using

angAzi = asin(sinHou*cosDec/sinZen) - azi;

Due to numerical noise the argument of asin can be slightly larger than 1 or slightly smaller than -1, which is invalid. This should be fixed by using IDEAS.BoundaryConditions.SolarGeometry.BaseClasses.SolarAzimuth.
@Mathadon Mathadon self-assigned this Oct 24, 2017
@Mathadon Mathadon added this to the Release 1.1 milestone Jan 11, 2018
@Mathadon Mathadon added the bug label Jan 11, 2018
Mathadon added a commit that referenced this issue Jan 21, 2018
@Mathadon
revised implementation of azimuth angle computation such that this ca…
aa82f95 
…nnot lead to infeasible computations

see #753
Mathadon added a commit that referenced this issue Jan 25, 2018
@Mathadon
fixed bug in revised azimuth computation
7598b54 
see #753
@Mathadon
Copy link
Member Author

The new implementation results in slightly different results (heat flow rates in the order of 1 mW), which can be due to regularisations etc.

@Mathadon Mathadon mentioned this issue Jan 25, 2018
Merged
@damienpicard
Copy link
Contributor

merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mathadon Mathadon

Labels
bug
Projects
None yet
Milestone
Release 2
Development

No branches or pull requests
2 participants
@damienpicard @Mathadon