Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1049 tutorial #1050

Merged
merged 6 commits into from
Sep 19, 2019
Merged

Issue1049 tutorial #1050

merged 6 commits into from
Sep 19, 2019

Conversation

Mathadon
Copy link
Member

@damienpicard can you review and merge this by the crash course?

@Mathadon Mathadon self-assigned this Sep 18, 2019
@damienpicard
Copy link
Contributor

@Mathadon this looks good. I just have 2 small remarks:

  • In example 4, you create an Occupancy model. It is unusual to create a model within a model. Are you sure you want that in a tutorial?
  • In example 5: you do not include solar shading nor occupancy. Wouldn't it be nice to add them? I 'm fine with both.

Once these comments are answered, this can be merged.

@Mathadon
Copy link
Member Author

  1. Is deliberate, to show that this can be done. It also helps keep the library clean for the purpose of this example. Otherwise, that occupancy model would always show up in IDEAS.
  2. Mostly because it's double work for the students, which I myself always find annoying.

@Mathadon Mathadon merged commit 2afba58 into master Sep 19, 2019
@Mathadon Mathadon deleted the issue1049_tutorial branch September 19, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants