election: Avoid holding the main lock for too long #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfsmig
changed the title
jfsmig
changed the title
jfsmig
changed the title
Codecov Report
@@ Coverage Diff @@
## 4.1.x #1364 +/- ##
=========================================
+ Coverage 76.7% 76.99% +0.28%
=========================================
Files 301 301
Lines 56287 56938 +651
Branches 6805 6831 +26
=========================================
+ Hits 43176 43837 +661
+ Misses 12953 12948 -5
+ Partials 158 153 -5
Continue to review full report at Codecov.
|
jfsmig
changed the title
(cherry picked from commit e1cd5b7)
(cherry picked from commit 08496d1)
As the upper bound of the exponential backoff. (cherry picked from commit c159f3a)
After failures in CHECKING_{SLAVES,MASTER}
The mechanism must be reviewed, for sub-second reactivity.
Weird case managed or the sake of robustness
Minor cosmetic change
When configured and allowed, prior to the election establishment.
jfsmig
changed the title
jfsmig
requested review from
murlock,
fvennetier and
kamel-rahim
and removed request for
fvennetier
fvennetier
reviewed
Apr 13, 2018
| GError *err = election_get_peers(M, &n, decache, &peers); | ||
|
|
||
| member_lock(m); | ||
| if (err || !peers || !*peers) { |
There was a problem hiding this comment.
We should probably do something with err, at least free it 😉
Thanks to @fvennetier, that is always watching!
Thanks to @fvennetier, once again!
Prior to this fix, a small window existed where DB could be created and be seen as READONLY from another thread.
Synchronuous completions are considered harmful, they slow the ZK background thread down.
iThe election can be computed out of the lock.
And mitigate a possible infinite recursion.
kamel-rahim
approved these changes
Apr 16, 2018
fvennetier
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolution of the peers is now deferred in tasks managed by a GThreadPool, out of any critical section. The decaching upon error is also postponed to the next resolution on that election.