Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account: do not try to decode "None" as UTF-8 #2074

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

AymericDu
Copy link
Member

@AymericDu AymericDu commented Aug 26, 2020

SUMMARY

Do not try to decode "None" as UTF-8. This error was frequent but unfortunately it was ignored by our tests.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • account
SDS VERSION
openio 7.0.2.dev13

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2020

Codecov Report

Merging #2074 into 7.x will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.x    #2074      +/-   ##
==========================================
- Coverage   78.45%   78.42%   -0.02%     
==========================================
  Files         378      378              
  Lines       73564    73565       +1     
  Branches     6571     6571              
==========================================
- Hits        57708    57689      -19     
- Misses      15651    15671      +20     
  Partials      205      205              
Impacted Files Coverage Δ
oio/account/backend.py 67.82% <100.00%> (-0.48%) ⬇️
tests/functional/content/test_service_id.py 78.83% <0.00%> (-5.88%) ⬇️
oio/common/easy_value.py 84.49% <0.00%> (-5.17%) ⬇️
metautils/lib/volume_lock.c 70.74% <0.00%> (-4.87%) ⬇️
tests/functional/audit/test_audit_storage.py 84.68% <0.00%> (-4.03%) ⬇️
oio/common/utils.py 67.38% <0.00%> (-2.43%) ⬇️
rdir/routes.c.rl 97.88% <0.00%> (-2.12%) ⬇️
tests/functional/cli/admin/test_item_check.py 70.26% <0.00%> (-2.05%) ⬇️
oio/content/plain.py 74.14% <0.00%> (-1.72%) ⬇️
meta1v2/meta1_server.c 69.68% <0.00%> (-1.63%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 316fa52...354df67. Read the comment docs.

oio/account/backend.py Outdated Show resolved Hide resolved
@fvennetier fvennetier changed the title account: Fix unseen exception account: do not try to decode "None" as UTF-8 Aug 28, 2020
@fvennetier fvennetier merged commit c92dac6 into open-io:7.x Sep 4, 2020
@AymericDu AymericDu deleted the account-fix-unseen-exception branch September 28, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants