Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add tests with tagging and upload #227

Merged
merged 1 commit into from
Oct 28, 2020
Merged

tests: add tests with tagging and upload #227

merged 1 commit into from
Oct 28, 2020

Conversation

murlock
Copy link
Contributor

@murlock murlock commented Oct 23, 2020

It requires this PR open-io/swift3#92 before merging

fvennetier
fvennetier reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@fvennetier fvennetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for these tests to be in a new script rather than the existing s3-tagging.sh script?

By the way, since there are several independent tests, I suggest to make several functions rather than a big one.

tests/functional/s3-tagging.py Outdated Show resolved Hide resolved
@murlock murlock changed the base branch from master to 1.x October 27, 2020 13:57
fvennetier
fvennetier approved these changes Oct 27, 2020
View reviewed changes
tests/functional/s3-tagging.py Outdated Show resolved Hide resolved
@murlock murlock merged commit d0ba0bf into open-io:1.x Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvennetier fvennetier fvennetier approved these changes

@AymericDu AymericDu AymericDu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@murlock @fvennetier @AymericDu