slo: Fix MPU with reserved characters #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AymericDu
requested review from
fvennetier,
thibault-p,
rdejoux,
Pofilo and
laitassou
cdelgehier
reviewed
Feb 1, 2022
| @@ -8,7 +8,7 @@ | |||
| import json | |||
| import os | |||
|
|
|||
| ENDPOINT = os.getenv("USE_ENDPOINT", "http://127.0.0.1:5000") | |||
| ENDPOINT = os.getenv("USE_ENDPOINT", "http://localhost:5000") | |||
There was a problem hiding this comment.
what is the purpose of this change in relation to your commit title?
There was a problem hiding this comment.
For several years, the path-style requests have been deprecated.
So, for the tests to work with the virtual hosted-style requests (but still with the path-style requests), we need to use the storage domain specified in the swift configuration.
Pofilo
approved these changes
Feb 1, 2022
fvennetier
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.