setup.py: relax pyparsing version restriction #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The need to restrict pyparsing to <3.0 seems to be unnecessary anymore. It is from the time when pyparsing-3 was pre-release candidate which was causing build failures. Original commit [1] locked pyparsing on specific version which was later relaxed to <3.0 [2]. pyparsing is currently in version 3.0.9 and it works fine with configshell-fb. [1] ec7ca0e ("setup.py: lets stick to pyparsing v2.4.7") [2] f1fd5a9 ("setup.py: specify a version range for pyparsing")
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Mar 2, 2023
Bug: https://bugs.gentoo.org/896764 Upstream-PR: open-iscsi/configshell-fb#69 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Mar 2, 2023
Bug: https://bugs.gentoo.org/896764 Upstream-PR: open-iscsi/configshell-fb#69 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 2, 2023
Bug: https://bugs.gentoo.org/896764 Upstream-PR: open-iscsi/configshell-fb#69 Signed-off-by: Petr Vaněk <arkamar@atlas.cz> Closes: #29893 Signed-off-by: Michał Górny <mgorny@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The need to restrict pyparsing to <3.0 seems to be unnecessary anymore. It is from the time when pyparsing-3 was pre-release candidate which was causing build failures. Original commit [1] locked pyparsing on specific version which was later relaxed to <3.0 [2]. pyparsing is currently in version 3.0.9 and it works fine with configshell-fb.
[1] ec7ca0e ("setup.py: lets stick to pyparsing v2.4.7")
[2] f1fd5a9 ("setup.py: specify a version range for pyparsing")