enable MaxOutstandingR2T negotiation #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iscsi_tcp kernel side R2T handling is in libiscsi_tcp and is shared with at least cxgbi3, and the drivers claim CAP_MULTI_R2T. But the iscsid login parameter negotiation code never enabled MaxOutstandingR2T. I've tested this against an LIO target, negotiating to 2 and 4 R2Ts. The network traces looked good, with the initiator keeping track of multiple outstanding R2Ts and using the correct next identifier. Throughput of bulk write data was improved, even over low latency virtio links. Signed-off-by: Chris Leech <cleech@redhat.com>
|
I'm good with this @cleech -- please feel free to integrate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iscsi_tcp kernel side R2T handling is in libiscsi_tcp and is shared
with at least cxgbi3, and the drivers claim CAP_MULTI_R2T. But the
iscsid login parameter negotiation code never enabled MaxOutstandingR2T.
I've tested this against an LIO target, negotiating to 2 and 4 R2Ts.
The network traces looked good, with the initiator keeping track of
multiple outstanding R2Ts and using the correct next identifier.
Throughput of bulk write data was improved, even over low latency virtio
links.
Signed-off-by: Chris Leech cleech@redhat.com