Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception if block pool name is incorrect #17

Closed
tasleson opened this issue Feb 16, 2017 · 0 comments
Closed

Exception if block pool name is incorrect #17

tasleson opened this issue Feb 16, 2017 · 0 comments

Comments

@tasleson
Copy link
Member

I incorrectly used vg-targetd/thinpool instead of vg-targetd/thin_pool in the configuration file. When I started the service it came up OK, but when I exercised the service I would get the following exception:

DEBUG:root:Traceback (most recent call last):
  File "/home/tasleson/projects/targetd-master/targetd/main.py", line 117, in do_POST
    result = mapping[method](self)
  File "/home/tasleson/projects/targetd-master/targetd/main.py", line 247, in pool_list
    return list(itertools.chain(block.block_pools(req), fs.fs_pools(req)))
  File "/home/tasleson/projects/targetd-master/targetd/block.py", line 340, in block_pools
    thinp = vg.lvFromName(tp_name)
LibLVMError: (0, '')

This should be improved so that we catch this as start-up and we exit with a nice error message instead of a cryptic stack exception.

tasleson added a commit to tasleson/targetd that referenced this issue Jul 5, 2019
Resolves: open-iscsi#17

Signed-off-by: Tony Asleson <tasleson@redhat.com>
tasleson added a commit to tasleson/targetd that referenced this issue Jul 5, 2019
Resolves: open-iscsi#17

Signed-off-by: Tony Asleson <tasleson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant