Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra: fix RPM build error #409

Merged
merged 1 commit into from Aug 8, 2018
Merged

Conversation

lxbsz
Copy link
Collaborator

@lxbsz lxbsz commented May 2, 2018

RPM build errors:
    Directory not found:
/root/tcmu-runner-orig/extra/rpmbuild/BUILDROOT/tcmu-runner-1.3.0.54.g6684a21-0.el7.centos.x86_64/etc/tcmu
    File not found:
/root/tcmu-runner-orig/extra/rpmbuild/BUILDROOT/tcmu-runner-1.3.0.54.g6684a21-0.el7.centos.x86_64/etc/tcmu/tcmu.conf
-----

Signed-off-by: Xiubo Li xiubli@redhat.com

@draghuram
Copy link
Contributor

Hi, Thanks for quick fix. I tried your script but am still seeing exact same errors as I posed in the list.

@lxbsz lxbsz force-pushed the rpm_error branch 2 times, most recently from a2aa7e5 to 9eaf4e4 Compare May 3, 2018 02:09
@lxbsz
Copy link
Collaborator Author

lxbsz commented May 3, 2018

@draghuram Yeah, please have a try again.

RPM build errors:
    Directory not found:
/root/tcmu-runner-orig/extra/rpmbuild/BUILDROOT/tcmu-runner-1.3.0.54.g6684a21-0.el7.centos.x86_64/etc/tcmu
    File not found:
/root/tcmu-runner-orig/extra/rpmbuild/BUILDROOT/tcmu-runner-1.3.0.54.g6684a21-0.el7.centos.x86_64/etc/tcmu/tcmu.conf
-----

Since from (commit a9e5bba) we had fixed the overwriting
about the exist tcmu.conf issue, so if the system's /etc/tcmu/tcmu.conf
is already exist, the cmake will skip intalling it.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz
Copy link
Collaborator Author

lxbsz commented Aug 8, 2018

@mikechristie
I have found the root cause and fixed in spec file.
Thanks,

@lxbsz
Copy link
Collaborator Author

lxbsz commented Aug 8, 2018

Updated it here.

@mikechristie
Copy link
Collaborator

Thanks.

@mikechristie mikechristie merged commit 3e0ff9d into open-iscsi:master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants