ignore randomly generated last octet of OIDs for ECKeys. fixes #2590 #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
msfjarvis
added a commit
to android-password-store/open-keychain
that referenced
this pull request
Feb 5, 2021
ignore randomly generated last octet of OIDs for ECKeys. fixes open-keychain#2590 * github.com:open-keychain/open-keychain: ignore randomly generated last octet of OIDs for ECKeys. fixes open-keychain#2590
|
Would be good to get this in as its stopping my key working. |
|
@dschuermann @Valodim can this be reviewed sometime soon? We still have many users who are unable to use their Yubikeys because of this. |
|
fixed with 2a0625e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As @schch already described in more detail in #2590 (comment), the last octet of the OID for ECKeys is randomly generated on insertion. This leads to a crash most of the time when trying to decrypt with a ECKey on a security token.
This PR ignores this last octet of the OID. And therefor fixes this bug/crash.
Motivation and Context
This PR fixes #2590. The problem was, that the OID with the random suffix was resolved to a
ECNamedCurveTable, which was unsuccessful. As this PR removes this suffix from the OID, the resoving works again. Therefor open-keychain does not anymore crash most of the time when trying to decrypt with a security token and an ECKey.How Has This Been Tested?
I have tested this change with my YubiKey on my phone and I successfully ran the testsuite.
Types of changes