Update for targetSdk34 #2876
Merged
Update for targetSdk34 #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valodim
force-pushed
the
sdk34
branch
2 times, most recently
from
c5da404
to
1bb3c22
Compare
The adaptations to SqlDelight 1.4.2 leave the type namings *extremely* messy. But it works and is as semantically equivalent as I could make it.
We don't have the notification permission reliably here, and the notification shows up and is gone so quickly that it provides little value anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the toolchain and all dependencies to new versions, cleans up some small bugs, fixes the recently reported security issue #2856 (its impact is not horrible).
Unfortunately due to sqldelight updates, it leaves the codebase somewhat messy because the getter names are now mixed camel snake case, which is unfortunately caused by automated kotlin/java getter naming. Refactoring to improve variable names would be a lot of extra effort (involving a database migration to boot), so I decided to leave it as is. It's probably easiest to migrate to kotlin to improve things there.