Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4596 tasks dropdown #4619

Merged
merged 3 commits into from Aug 22, 2019
Merged

4596 tasks dropdown #4619

merged 3 commits into from Aug 22, 2019

Conversation

anishregmee
Copy link
Member

thank you for the review

paulbert
paulbert requested changes Aug 20, 2019
View reviewed changes
Copy link
Member

@paulbert paulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's implement as a pipe instead since that will be better for change detection.

https://angular.io/guide/pipes#flyingheroespipe

@paulbert paulbert merged commit c98dd1a into master Aug 22, 2019
@paulbert paulbert deleted the 4596-tasks-dropdown branch August 22, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbert paulbert paulbert approved these changes

@lmmrssa lmmrssa Awaiting requested review from lmmrssa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anishregmee @paulbert