Feature PHPDoc check #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabalin
force-pushed
the
feature-PHPDoc-check
branch
from
9285a32
to
522f9c5
Compare
polothy
suggested changes
Dec 17, 2018
Instead of directory, use MoodlePlugin::getFiles call to identify the list of files required for testing and pass them to moodlecheck cli script.
|
Hello @polothy |
|
Heh, previous build apparently failed on phpdoc check 😃(https://travis-ci.org/blackboard-open-source/moodle-plugin-ci/jobs/481097455#L728) Fixed in b58488f. |
polothy
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds phpdoc check using moodle-local_moodlecheck plugin (closing #10).
This command does not include command unittest though, as opposed to other commands, in order to be able to run phpdoc check as a part of unittest, a full Moodle installation is required (local_moodlecheck is using core moodle functions). If unittest is required, I guess I need to add an alternative to MoodleTestCase that would included cloning process instead of using fixture and use it for this command test.