Fix: issue-3216 Data Quality - Min and Max value config error (#3218)

open-metadata · Mar 7, 2022 · 8c7933c · 8c7933c
1 parent 954908e
commit 8c7933c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...adata-ui/src/main/resources/ui/src/components/AddDataQualityTest/Forms/ColumnTestForm.tsx b/...adata-ui/src/main/resources/ui/src/components/AddDataQualityTest/Forms/ColumnTestForm.tsx
@@ -159,8 +159,8 @@ const ColumnTestForm = ({
       case ColumnTestType.columnValueLengthsToBeBetween:
       case ColumnTestType.columnValuesToBeBetween:
         errMsg.minOrMax = isEmpty(minValue) && isEmpty(maxValue);
-        if (!isEmpty(minValue) && !isEmpty(maxValue)) {
-          errMsg.minMaxValue = (minValue as number) > (maxValue as number);
+        if (!isUndefined(minValue) && !isUndefined(maxValue)) {
+          errMsg.minMaxValue = (+minValue as number) > (+maxValue as number);
         }
 
         break;

diff --git a/...tadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/Forms/TableTestForm.tsx b/...tadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/Forms/TableTestForm.tsx
@@ -103,8 +103,8 @@ const TableTestForm = ({
 
     if (isTableRowCountToBeBetweenTest) {
       errMsg.minOrMax = isEmpty(minValue) && isEmpty(maxValue);
-      if (!isEmpty(minValue) && !isEmpty(maxValue)) {
-        errMsg.minMaxValue = (minValue as number) > (maxValue as number);
+      if (!isUndefined(minValue) && !isUndefined(maxValue)) {
+        errMsg.minMaxValue = (+minValue as number) > (+maxValue as number);
       }
     } else {
       errMsg.values = isEmpty(value);