Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sample_data failure on run_local_docker.sh #2801

Closed
pmbrull opened this issue Feb 16, 2022 · 0 comments
Closed

Handle sample_data failure on run_local_docker.sh #2801

pmbrull opened this issue Feb 16, 2022 · 0 comments
Assignees
Labels
bug Something isn't working P1 High priority

Comments

@pmbrull
Copy link
Collaborator

pmbrull commented Feb 16, 2022

Affected module
CI tests

Describe the bug
When there are changes impacting the correct behavior of the sample data ingestion, we are currently not picking up any errors. Instead, we let the py-tests CI pipeline timeout, which can be ignored during merging.

To Reproduce

Screenshots or steps to reproduce

Expected behavior
We should properly raise an explicit fail during run_local_docker.sh when this happens. It might be tricky as the pipeline runs automatically in the ingestion container, but we might be able to ping the pipeline status.

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 High priority
Projects
No open projects
Development

No branches or pull requests

3 participants