Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2937: added clickhouse usage connector #2987

Merged
merged 1 commit into from Feb 26, 2022

Conversation

ulixius9
Copy link
Member

Describe your changes :

Fix #2937: added clickhouse usage connector

Type of change :

  • New feature

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@harshach @ayush-shah @pmbrull

@pmbrull
Copy link
Collaborator

pmbrull commented Feb 25, 2022

Hi, @ulixius9, thanks for the PR! It LGTM, just please review that you can run the Docker's correctly on your end with the requirement change.

Even if the py-tests CI shows as a timeout, it usually happens due to an issue trying to spin up the Airflow container or the sample_data pipeline failing. We have an open issue to treat this more explicitly #2801

Thanks!

@harshach harshach merged commit e79be68 into open-metadata:main Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Usage connector for Clickhouse
3 participants