Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge openmetadata.yaml and openmetadata-server.yaml #2807

Closed
harshach opened this issue Feb 16, 2022 · 1 comment
Closed

Merge openmetadata.yaml and openmetadata-server.yaml #2807

harshach opened this issue Feb 16, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request P1 High priority

Comments

@harshach
Copy link
Collaborator

Feature
Currently we keep non-secure configs in openmetadata.yaml and secure configs openmetadata-server.yaml.
Our ./bin/openmetadata-server-start.sh uses conf/openmetadata.yaml as the default config
It not only confuses our users but also hard to make the docker to go from non-secure to secure setup.

Describe the task
Have all the secure configs in openmetadata.yaml with authenticationConfiguration and authorizerConfiguration along with environment variables to secure those.
By default these will have non-secure configs. This will allow any interested users to continue to test OpenMetadata without securing through google or okta

@harshach harshach added enhancement New feature or request P1 High priority labels Feb 16, 2022
@harshach harshach added this to the Milestone 3 - 0.9.0 Release milestone Feb 16, 2022
@harshach harshach self-assigned this Feb 16, 2022
@harshach harshach added this to To do in Release 0.9.0 via automation Feb 16, 2022
@harshach
Copy link
Collaborator Author

@Sachin-chaurasiya @darth-coder00 currently the UI tries to redirect the UI to auth provider if it sees authenticationConfiguration.
With this patch we want to support both secure/non-secure using environment variables.
Default configs you'll get

{
provider: "no-auth",
publicKey: "https://www.googleapis.com/oauth2/v3/certs",
authority: "https://accounts.google.com/",
clientId: "",
callbackUrl: ""
}

if you see no-auth do not redirect users to sign-in. This behavior should be same as when the user doesn't have any auth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 High priority
Projects
No open projects
Development

No branches or pull requests

1 participant