Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ability to select a role as default from the UI #2874

Closed
mithmatt opened this issue Feb 20, 2022 · 4 comments · Fixed by #3145
Closed

Support ability to select a role as default from the UI #2874

mithmatt opened this issue Feb 20, 2022 · 4 comments · Fixed by #3145
Assignees
Labels
P1 High priority UI UI specific issues

Comments

@mithmatt
Copy link
Collaborator

mithmatt commented Feb 20, 2022

See mocks in #3057

@mithmatt mithmatt added the UI UI specific issues label Feb 20, 2022
@mithmatt
Copy link
Collaborator Author

cc: @harshach @Sachin-chaurasiya

@mithmatt mithmatt assigned mithmatt and unassigned mithmatt Feb 20, 2022
@mithmatt
Copy link
Collaborator Author

mithmatt commented Feb 20, 2022

All backend code changes required for this feature has been landed

Noteworthy APIs:

Get a list of default roles
GET /roles?default=true

Get role and check default field (boolean)

GET /roles/:roleId

{
    "data": [
        {
            "id": "8cab99aa-532e-4669-8371-e6aa585a719d",
            "name": "DataConsumer",
            "displayName": "Data Consumer",
            "description": "Users with Data Consumer role use different data assets for their day to day work.",
            "version": 0.2,
            "updatedAt": 1645393642364,
            "updatedBy": "admin",
            "href": "http://localhost:8585/api/v1/roles/8cab99aa-532e-4669-8371-e6aa585a719d",
            "default": true
        }
  ]
}

Update role to be set as default (it also removes default from other existing roles)

PATCH /roles/:roleId

[{"op":"replace","path":"/default","value":true}]

@mithmatt mithmatt added this to To do in Release 0.9.0 via automation Feb 20, 2022
@mithmatt mithmatt added the P1 High priority label Feb 20, 2022
@mithmatt
Copy link
Collaborator Author

Copied priority and project labels from #2460

@mithmatt
Copy link
Collaborator Author

cc: @harshach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority UI UI specific issues
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants