Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2874Support ability to select a role as default from the UI #3145

Merged
merged 1 commit into from Mar 4, 2022
Merged

Fix #2874Support ability to select a role as default from the UI #3145

merged 1 commit into from Mar 4, 2022

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented Mar 4, 2022 •
edited

Closes #2874

Describe your changes :

I worked on issue #2874

Type of change :

  • Improvement
  • New feature

Frontend Preview (Screenshots) :

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@shahsank3t, @darth-coder00

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Mar 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Sachin-chaurasiya Sachin-chaurasiya merged commit 13e24c5 into main Mar 4, 2022
@Sachin-chaurasiya Sachin-chaurasiya deleted the issue-2874 branch March 4, 2022 12:41
darth-coder00
darth-coder00 reviewed Mar 4, 2022
View reviewed changes
Copy link
Contributor

@darth-coder00 darth-coder00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes to take care of in next PR

openmetadata-ui/src/main/resources/ui/src/axiosAPIs/userAPI.ts

export const getUserCounts = () => {
return APIClient.get(
'/search/query?q=*&from=0&size=0&index=user_search_index'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use SearchIndex enum to pass index here

...adata-ui/src/main/resources/ui/src/components/Modals/ConfirmationModal/ConfirmationModal.tsx
@@ -17,7 +17,7 @@ import { Button } from '../../buttons/Button/Button';
type Props = {
cancelText: string | ReactNode;
confirmText: string | ReactNode;
bodyText: string;
bodyText: string | ReactNode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also support Array<ReactNode> incase of multiple elements in future from some other component.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darth-coder00 ReactNode by default support these types.

ReactChild | ReactFragment | ReactPortal | boolean | null | undefined;

So we don't have to do Array<ReactNode>, ReactNode will be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darth-coder00 darth-coder00 darth-coder00 left review comments

@shahsank3t shahsank3t shahsank3t approved these changes

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ability to select a role as default from the UI
3 participants
@Sachin-chaurasiya @shahsank3t @darth-coder00