Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingestion: show better error messages #2901

Closed
harshach opened this issue Feb 21, 2022 · 0 comments · Fixed by #2917
Closed

Ingestion: show better error messages #2901

harshach opened this issue Feb 21, 2022 · 0 comments · Fixed by #2917
Assignees
@ulixius9
Labels
enhancement New feature or request Ingestion
Projects
Release 0.9.0
Milestone
Milestone 4 - 0.9...

Comments

@harshach
Copy link
Collaborator

Feature
Ingestion looks up a service_name based on the ingestion config and associate databases, tables underneath them.
If the service_name is not found it will go and creates it for the users. During this process we throw errors

Although this is expected behavior, showing an error creates confusion among users.
We should instead cleanup and not throw ERROR
isntead "sample_s3" service not found, creating "sample_s3" service.
@harshach harshach added enhancement New feature or request Ingestion labels Feb 21, 2022
@harshach harshach added this to the Milestone 4 - 0.9.0 Release milestone Feb 21, 2022
@harshach harshach added this to To do in Release 0.9.0 via automation Feb 21, 2022
@ayush-shah ayush-shah moved this from To do to In progress in Release 0.9.0 Feb 22, 2022
ulixius9 added a commit to ulixius9/OpenMetadata that referenced this issue Feb 22, 2022
@ulixius9
Fix open-metadata#2901: fixed error message
540ec87
@ulixius9 ulixius9 mentioned this issue Feb 22, 2022
Merged
8 tasks
Release 0.9.0 automation moved this from In progress to Done Feb 22, 2022
ayush-shah pushed a commit that referenced this issue Feb 22, 2022
@ulixius9
Fix #2901: fixed error message (#2917)
f9182a6 
* Fix #2901: fixed error message

* moved error message to helper.py

* replaced error to http
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulixius9 ulixius9

Labels
enhancement New feature or request Ingestion
Projects
No open projects
Release 0.9.0
Done
Milestone
Milestone 4 - 0.9.0 Release
Development

Successfully merging a pull request may close this issue.

Fix #2901: fixed error message ulixius9/OpenMetadata
2 participants
@harshach @ulixius9