Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary-term suggest api has fqdn same as name #3051

Closed
darth-coder00 opened this issue Mar 1, 2022 · 0 comments
Closed

Glossary-term suggest api has fqdn same as name #3051

darth-coder00 opened this issue Mar 1, 2022 · 0 comments
Assignees
Labels
backend bug Something isn't working P0 Highest priority

Comments

@darth-coder00
Copy link
Contributor

Affected module
Does it impact the UI, backend or Ingestion Framework? - backend (ES)

Describe the bug
In Suggestions api for glossary-term, fqdn is same as name field - it does not include parent-term or glossary name in fqdn

To Reproduce
Refer api response for http://localhost:8585/api/v1/search/suggest?q=sh&index=glossary_search_index

{
  "suggest": {
    "table-suggest": [
      {
        "text": "sh",
        "offset": 0,
        "length": 2,
        "options": [
          {
            "text": "shirt",
            "_index": "glossary_search_index",
            "_type": "_doc",
            "_id": "145546fe-6599-4eee-a4b6-8240cab5afa4",
            "_score": 10,
            "_source": {
              "name": "shirt",
              "fqdn": "shirt",   `Look at the fqdn and name fields here`
              "suggest": [
                {
                  "input": "shirt",
                  "weight": 5
                },
                {
                  "input": "shirt",
                  "weight": 10
                }
              ],
              "description": "It is a long established fact that a reader will be distracted by the readable content of a page when looking at its layout. The point of using Lorem Ipsum is that it has a more-or-less normal distribution of letters, as opposed to using 'Content here, content here', making it look like readable English. Many desktop publishing packages and web page editors now use Lorem Ipsum as their default model text, and a search for 'lorem ipsum' will uncover many web sites still in their infancy. Various versions have evolved over the years, sometimes by accident, sometimes on purpose (injected humour and the like).",
              "tags": [],
              "display_name": "shirt",
              "entity_type": "glossaryTerm",
              "last_updated_timestamp": 1646129922503,
              "glossary_id": "443d704e-af97-4cc3-a38c-f7e4c3c765ce",
              "glossary_name": "business glossary"
            }
          }
        ]
      }
    ]
  }
}

Expected behavior
fqdn should have value business glossary.clothing.shirt , where clothing is the parent glossary-term

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
None

@darth-coder00 darth-coder00 added this to To do in Release 0.9.0 via automation Mar 1, 2022
@darth-coder00 darth-coder00 added backend bug Something isn't working P0 Highest priority labels Mar 1, 2022
Release 0.9.0 automation moved this from To do to Done Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working P0 Highest priority
Projects
No open projects
Development

No branches or pull requests

2 participants