Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary Improvements #7074

Closed
10 of 12 tasks
harshach opened this issue Aug 31, 2022 · 12 comments
Closed
10 of 12 tasks

Glossary Improvements #7074

harshach opened this issue Aug 31, 2022 · 12 comments
Assignees
Labels
backend epic P0 Highest priority UI UI specific issues

Comments

@harshach
Copy link
Collaborator

harshach commented Aug 31, 2022

Is your feature request related to a problem? Please describe.
for 0.12.1 we need to improve several aspects of Glossary. Below captures a few details of what we want to achieve in the Glossary for 0.12.1

Describe the solution you'd like

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Related issues

  • ...
@harshach
Copy link
Collaborator Author

harshach commented Aug 31, 2022

@trillhaa
Copy link

Two more suggestions (second is a bit of a long-shot):

  1. Set Asset as "Primary Asset" for a given glossary term: There might be many tables associated to one Glossary term, but one table is the base/key table. I should be able to mark one table /asset as "primary" for that glossary term.
  2. Auto-assign glossary terms to columns/assets based on exact string matches. This would be a huge improvement.

@harshach
Copy link
Collaborator Author

@ShaileshParmar11 @devyani-kaushik lets pick few of these todos for 0.12.1

@vivekratnavel
Copy link
Contributor

vivekratnavel commented Sep 13, 2022

Screen.Recording.2022-09-13.at.12.03.45.PM.mov

Response:

{"data":[{"id":"4ab215ee-7854-4455-9078-7ea0ee819fed","name":"Test ","displayName":"Test ","description":"Testing here","fullyQualifiedName":"Test Service.Test ","synonyms":["Random"],"glossary":{"id":"8f94f9a9-2756-4b7f-99a8-459117c0e462","type":"glossary","name":"Test Service","fullyQualifiedName":"Test Service","description":"test","displayName":"Test Service","deleted":false,"href":"http://sandbox-beta.open-metadata.org/api/v1/glossaries/8f94f9a9-2756-4b7f-99a8-459117c0e462"},"children":[],"relatedTerms":[{"id":"4ab215ee-7854-4455-9078-7ea0ee819fed","type":"glossaryTerm","name":"Test ","fullyQualifiedName":"Test Service.Test ","description":"Testing here","displayName":"Test ","deleted":false,"href":"http://sandbox-beta.open-metadata.org/api/v1/glossaryTerms/4ab215ee-7854-4455-9078-7ea0ee819fed"},{"id":"4ab215ee-7854-4455-9078-7ea0ee819fed","type":"glossaryTerm","name":"Test ","fullyQualifiedName":"Test Service.Test ","description":"Testing here","displayName":"Test ","deleted":false,"href":"http://sandbox-beta.open-metadata.org/api/v1/glossaryTerms/4ab215ee-7854-4455-9078-7ea0ee819fed"}],"references":[{"name":"Test Service","endpoint":"https://github.com/open-metadata/OpenMetadata/issues/7248"}],"version":0.7,"updatedAt":1663095766554,"updatedBy":"vivek","href":"http://sandbox-beta.open-metadata.org/api/v1/glossaryTerms/4ab215ee-7854-4455-9078-7ea0ee819fed","reviewers":[],"tags":[{"tagFQN":"PersonalData.Personal","description":"Data that can be used to directly or indirectly identify a person.","source":"Tag","labelType":"Manual","state":"Confirmed"},{"tagFQN":"PersonalData.SpecialCategory","description":"GDPR special category data is personal information of data subjects that is especially sensitive, the exposure of which could significantly impact the rights and freedoms of data subjects and potentially be used against them for unlawful discrimination.","source":"Tag","labelType":"Manual","state":"Confirmed"},{"tagFQN":"PII.None","description":"Non PII","source":"Tag","labelType":"Manual","state":"Confirmed"},{"tagFQN":"PII.NonSensitive","description":"PII which is easily accessible from public sources and can include zip code, race, gender, and date of birth.","source":"Tag","labelType":"Manual","state":"Confirmed"}],"changeDescription":{"fieldsAdded":[],"fieldsUpdated":[],"fieldsDeleted":[{"name":"tags","oldValue":"[{\"tagFQN\":\"PII.Sensitive\",\"description\":\"PII which if lost, compromised, or disclosed without authorization, could result in substantial harm, embarrassment, inconvenience, or unfairness to an individual.\",\"source\":\"Tag\",\"labelType\":\"Manual\",\"state\":\"Confirmed\"}]"}],"previousVersion":0.6},"status":"Draft","deleted":false}],"paging":{"total":1}}

@sureshms
Copy link
Contributor

sureshms commented Sep 13, 2022

@vivekratnavel
Copy link
Contributor

vivekratnavel commented Sep 14, 2022

  • Fix Glossary menu inconsistency while navigating between Related Terms
190272738-485c481a-193c-409c-bfe9-3e223b3830d2.mov

@ShaileshParmar11
Copy link
Contributor

  • Fix Glossary menu inconsistency while navigating between Related Terms

190272738-485c481a-193c-409c-bfe9-3e223b3830d2.mov

Hello, @vivekratnavel I am not able to reproduce the mentioned issue!
are there any specific steps that need to be followed?

Screen.Recording.2022-09-24.at.9.09.45.PM.mov

@vivekratnavel
Copy link
Contributor

Hi @ShaileshParmar11, I don't have any specific steps. If you are not able to reproduce it, then we can mark it resolved. Thank you!

@vivekratnavel
Copy link
Contributor

@ShaileshParmar11, I was able to reproduce the issue. Can you please check?

Screen.Recording.2022-09-28.at.12.17.11.PM.mov

@TeddyCr
Copy link
Contributor

TeddyCr commented Sep 30, 2022

@harshach can I take "Bulk upload of Glossary Terms - P1 - 0.13.0"?

@ShaileshParmar11 ShaileshParmar11 removed their assignment Oct 10, 2022
@vivekratnavel vivekratnavel removed their assignment Nov 10, 2022
@sureshms sureshms self-assigned this Nov 14, 2022
@harshach harshach closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend epic P0 Highest priority UI UI specific issues
Projects
No open projects
Status: Done
Development

No branches or pull requests

9 participants