Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvements 0.13 #8513

Closed
7 tasks done
devyani-kaushik opened this issue Nov 3, 2022 · 20 comments · Fixed by #8952
Closed
7 tasks done

UI Improvements 0.13 #8513

devyani-kaushik opened this issue Nov 3, 2022 · 20 comments · Fixed by #8952
Assignees
Labels
UI UI specific issues

Comments

@devyani-kaushik
Copy link

devyani-kaushik commented Nov 3, 2022

  • change "Delete Catagory" button styling to secondary

Screenshot 2022-11-03 at 11 15 53 AM

  • Left and right padding is not consistent on all pages

Screenshot 2022-11-03 at 11 17 47 AM

Screenshot 2022-11-03 at 11 17 59 AM

Screenshot 2022-11-03 at 11 18 12 AM

Screenshot 2022-11-03 at 11 18 38 AM

  • Left Column needs to have fixed height

Screenshot 2022-11-03 at 11 19 28 AM

  • Can we add an empty table when no data is available ?

Screenshot 2022-11-03 at 11 26 45 AM

  • Delete icon getting cropped in user list

Screenshot 2022-11-03 at 11 44 30 AM

  • Table styling not consistent

Screenshot 2022-11-03 at 11 46 48 AM

  • need to update the right documentation link

Screenshot 2022-11-03 at 11 51 48 AM

@devyani-kaushik
Copy link
Author

devyani-kaushik commented Nov 8, 2022

  • Need to fix spacing after you add a tag to the table

Screenshot 2022-11-08 at 8 47 50 AM

  • need to fix spacing here (top & bottom padding)

Screenshot 2022-11-08 at 8 52 55 AM

  • table styling not consistent on this page

Screenshot 2022-11-08 at 8 54 05 AM

  • Left column spacing and width not consistent

Screenshot 2022-11-08 at 9 04 42 AM

Screenshot 2022-11-08 at 9 04 25 AM

@aniketkatkar97 aniketkatkar97 added the UI UI specific issues label Nov 9, 2022
@chirag-madlani
Copy link
Collaborator

chirag-madlani commented Nov 9, 2022

  • Glossary tree icons are missaligned

Screenshot 2022-11-09 at 8 02 09 PM

@Sachin-chaurasiya
Copy link
Member

Sachin-chaurasiya commented Nov 14, 2022

image

@Sachin-chaurasiya
Copy link
Member

Sachin-chaurasiya commented Nov 14, 2022

  • The dropdown icon is not aligned properly.

Image

@pmbrull
Copy link
Collaborator

pmbrull commented Nov 14, 2022

Services > Openmetadata Service

  • Display name should be OpenMetadata Service, not Openmetadata -> I guess we'll need to change this in the backend @mohityadav766. Ping us when you do this change as we'll need to update ingestion code

  • JWT Token should be masked -> @Ashish8689

  • 🚨 I'd disable the Test Connection in the Connection tab, at least for now. There is no implementation behind that -> @Ashish8689
    image

  • 🚨 Fetching logs from ElasticSearch reindex pipeline does not work. Task name is elasticsearch_reindex_task. Same for the Data Insights pipeline, the task name there is data_insight_task -> @mohityadav766 will raise a PR to fix this

  • In Metadata Services > OpenMetadata: Rename from Add Elastic Search Reindex Ingestion to Add Elasticsearch Reindex -> @Ashish8689

image

  • The breadcrumb when adding the Elasticsearch reindex pipeline has a typo -> @aniketkatkar97
  • 🚨 Show titles and descriptions when adding the Elasticsearch reindex pipeline. The JSON Schema already has all the necessary information for us to render
    image

@mohityadav766
Copy link
Contributor

Services > Openmetadata Service

  • Display name should be OpenMetadata Service, not Openmetadata -> I guess we'll need to change this in the backend @mohityadav766. Ping us when you do this change as we'll need to update ingestion code
  • JWT Token should be masked
  • I'd disable the Test Connection in the Connection tab, at least for now. There is no implementation behind that

image

@pmbrull , corrected the first one should take changes on the ui

@Ashish8689
Copy link
Contributor

Ashish8689 commented Nov 15, 2022

  • Search bar get small while redirecting to any

image

  • Horizontal scrollbar is visible on every page -> @Ashish8689

image

@Sachin-chaurasiya
Copy link
Member

Sachin-chaurasiya commented Nov 15, 2022

  • This text is too prominent here.

image

@devyani-kaushik
Copy link
Author

devyani-kaushik commented Nov 16, 2022

Change matadata Icon on settings page to svg shared below. -> @Ashish8689

  • metadata

image

@Sachin-chaurasiya
Copy link
Member

Sachin-chaurasiya commented Nov 16, 2022

  • On UI for labels replace entity with data asset and entities with data assets -> @aniketkatkar97

@devyani-kaushik
Copy link
Author

devyani-kaushik commented Nov 17, 2022

all will be handled by @aniketkatkar97

  • bottom padding of the filters can be reduced a little
  • fix the position of filter
  • Filters should inherit the icons
  • card spacing should be 16px

Screenshot 2022-11-17 at 10 59 14 AM

@ulixius9
Copy link
Member

ulixius9 commented Nov 17, 2022

  • parentheses missing even though available in api response in dataTypeDisplay -> @Ashish8689

image

@Sachin-chaurasiya
Copy link
Member

Sachin-chaurasiya commented Nov 18, 2022

image

@Sachin-chaurasiya
Copy link
Member

Sachin-chaurasiya commented Nov 18, 2022

  • @Ashish8689, Disable the test connection button for matadata service on the edit connection page.

image

@Sachin-chaurasiya
Copy link
Member

Sachin-chaurasiya commented Nov 18, 2022

image

image

@harshach
Copy link
Collaborator

harshach commented Nov 18, 2022

  • font sizes and arrows look out of place compare to others we use -> @aniketkatkar97

image

  • @chirag-madlani we shouldn't be showing the list view and DAG view in the same page. It should be switchable button that can switch from list to DAG view. Default should be switch view -> @Ashish8689

image

@harshach
Copy link
Collaborator

harshach commented Nov 18, 2022

image

@aniketkatkar97
Copy link
Member

aniketkatkar97 commented Nov 18, 2022

Screenshot 2022-11-18 at 3 59 18 PM

aniketkatkar97 added a commit that referenced this issue Nov 18, 2022
* - Converted normal table to antd table for 'Service Page'
- Table styling made consistent
- Fixed delete icon issue on UsersList page
- Code optimisations

* Fixed failing unit tests for service page

* Used antd Card component instead of Row/Col in 'Service', 'DatabaseDetails' and 'DatabaseSchema' pages

* Code optimisation and eleminated duplications

* Reverted the changes for Using Card component instad of Row/Col

* - Fixed cypress tests
- Localisation changes

* Fixed unit tests

* fixed acitvity feed and task label
chirag-madlani pushed a commit that referenced this issue Nov 19, 2022
* Added colored svgs to show on feed and thread type filter selection

* updated spacing between activity feed cards

* Improved the filters styling on my-data page

* Fixed alignment for activity filters container on 'Activity Feeds & Tasks' tab

* Changed z-index for filter container to allow popovers to show on top

* Added no data placeholder in ActivityFeedList component for no data found for selected filters

* Fixed dropdown icon alignment for ActivityFeedList

* Worked on comments
Removed use of !important from css
Removed tailwind css changes

* fixed failing cypress tests

Co-authored-by: Nahuel Verdugo Revigliono <nahuel@getcollate.io>
chirag-madlani added a commit that referenced this issue Nov 19, 2022
* Removed highlighting on hover of data cards for data assets other than table

* Fixed alignment issues in Executions tab for pipelines

* Entity summary panel profiler data styling changed

* Added vector svg to use in Executions tab

* Changed OM logo to show on services page for Openmetadata Service

* Fixed Breadcrumb typo for add ingestion page
Replaced 'entity' with 'data asset'
Localisation

* Fixed version page bug

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
@devyani-kaushik
Copy link
Author

devyani-kaushik commented Nov 22, 2022

  • Update the label styling to >> color: #6B7280 and font-weight: 500

Screenshot 2022-11-22 at 11 58 09 AM

  • Use the announcement icon in list for both the places.

Screenshot 2022-11-22 at 11 56 49 AM

@ShaileshParmar11
Copy link
Contributor

ShaileshParmar11 commented Nov 22, 2022

@Sachin-chaurasiya Sachin-chaurasiya linked a pull request Nov 22, 2022 that will close this issue
5 tasks
@harshach harshach mentioned this issue Dec 7, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI UI specific issues
Projects
No open projects
Status: 🔖 Ready
Development

Successfully merging a pull request may close this issue.

10 participants