Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed#10211: Enable LDAP configuration to be configured via environment variable #10252

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Fixed#10211: Enable LDAP configuration to be configured via environment variable #10252

merged 2 commits into from
Feb 22, 2023

Conversation

parthp2107
Copy link
Contributor

Describe your changes :

Fixes #10211

Type of change :

  • Improvement
  • New feature
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@mohityadav766

@parthp2107 parthp2107 requested a review from a team as a code owner February 21, 2023 10:26
@NiharDoshi99 NiharDoshi99 added the safe to test Add this label to run secure Github workflows on PRs label Feb 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cypress
Copy link

cypress bot commented Feb 21, 2023 •
edited
Loading

4 failed tests on run #15686 ↗︎

4 222 2 0 Flakiness 0

Details:

Fixed#10211: Enable LDAP configuration to be configured via environment variable
Project: openmetadata Commit: 149adf9901
Status: Failed Duration: 07:12 💡
Started: Feb 21, 2023 10:47 AM Ended: Feb 21, 2023 11:55 AM
Failed  kafka.spec.js • 2 failed tests • Tests with database mysql

View Output Video

Test
Kafka Ingestion > add and ingest data Screenshot
Kafka Ingestion > Update table description and verify description after re-run Screenshot
Failed  mysql.spec.js • 2 failed tests • Tests with database mysql

View Output Video

Test
MySQL Ingestion > add and ingest data Screenshot
MySQL Ingestion > Update table description and verify description after re-run Screenshot

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

[OpenMetadata-catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug E 28 Bugs
Vulnerability B 2 Vulnerabilities
Security Hotspot E 9 Security Hotspots
Code Smell A 596 Code Smells

0.0% 0.0% Coverage
2.8% 2.8% Duplication

@mohityadav766 mohityadav766 merged commit 9bd2236 into open-metadata:main Feb 22, 2023
@mohityadav766 mohityadav766 temporarily deployed to publish February 22, 2023 07:23 — with GitHub Actions Inactive
mohityadav766 pushed a commit that referenced this pull request Mar 3, 2023
@parthp2107 @mohityadav766
Fixed#10211: Enable LDAP configuration to be configured via environme…
0d085d4 
…nt variable (#10252)

* Fixed#10211: Enable LDAP configuration to be configured via environment variable

* Fixed#10211: Enable LDAP configuration to be configured via environment variable

(cherry picked from commit 9bd2236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees

@parthp2107 parthp2107

Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable LDAP configuration to be configured via environment variable
3 participants
@parthp2107 @mohityadav766 @NiharDoshi99