Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #14117: ElasticSearch index creation error in JP #14118

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Issue #14117: ElasticSearch index creation error in JP #14118

merged 3 commits into from
Nov 28, 2023

Conversation

shin1103
Copy link
Contributor

@shin1103 shin1103 commented Nov 26, 2023 •
edited by harshach

Describe your changes:

Fixes #14117

  • File names are now the same as the EN ones.
  • Fix type om_analyzer to om_analyzer_jp

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@shin1103 shin1103 requested a review from a team as a code owner November 26, 2023 21:53
@github-actions GitHub Actions
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harshach harshach added the safe to test Add this label to run secure Github workflows on PRs label Nov 27, 2023
@harshach
Copy link
Collaborator

Thanks for the fix @shin1103

@harshach harshach changed the title Fixes 14117: ElasticSearch index creation error in JP Issue #14117: ElasticSearch index creation error in JP Nov 27, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harshach harshach merged commit 6ad3b61 into open-metadata:main Nov 28, 2023
15 of 21 checks passed
@yukiyan yukiyan mentioned this pull request Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
No open projects
Release 1.2.3
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't create ElasticSearch JP index in migrate-all process
2 participants
@shin1103 @harshach