Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 14286: Transpose row=None before try statement in compute_metrics_in_thread function #14287

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fixes 14286: Transpose row=None before try statement in compute_metrics_in_thread function #14287

merged 2 commits into from
Dec 21, 2023

Conversation

aldwyn
Copy link
Contributor

@aldwyn aldwyn commented Dec 7, 2023 •
edited

Transpose row=None before try statement in compute_metrics_in_thread function

Describe your changes:

Fixes #14286

I worked on transposing row=None before try statement in compute_metrics_in_thread function because it garners the following error: local variable 'row' referenced before assignment

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aldwyn
Update profiler_interface.py
1b95edd 
Transpose row=None before try statement in compute_metrics_in_thread function
@aldwyn aldwyn requested a review from a team as a code owner December 7, 2023 04:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@aldwyn aldwyn changed the title Transpose row=None before try statement in compute_metrics_in_thread function #14286 Transpose row=None before try statement in compute_metrics_in_thread function Dec 7, 2023
@aldwyn aldwyn mentioned this pull request Dec 7, 2023
Closed
@aldwyn aldwyn changed the title Transpose row=None before try statement in compute_metrics_in_thread function Fixes 14286: Transpose row=None before try statement in compute_metrics_in_thread function Dec 7, 2023
@pmbrull pmbrull added the safe to test Add this label to run secure Github workflows on PRs label Dec 21, 2023
pmbrull
pmbrull approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pmbrull pmbrull merged commit 0e4f808 into open-metadata:main Dec 21, 2023
14 checks passed
pmbrull added a commit that referenced this pull request Dec 21, 2023
@aldwyn @pmbrull
Update profiler_interface.py (#14287)
672e14a 
Transpose row=None before try statement in compute_metrics_in_thread function

Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Local variable 'row' referenced before assignment" when running Snowflake profiler ingestion
2 participants
@aldwyn @pmbrull