Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added localization file nl-nl #14597

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

sandervanlaar
Copy link
Contributor

Describe your changes:

Fixes n/a
Added a localization file for the Dutch language (nl-nl). The company I work for is a Dutch-spoken organization, so there was a need for Dutch labels, messages, etcetera. I translated all values in the JSON file.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

New feature

  • The issue properly describes why the new feature is needed, what's the goal, and how we are building it. Any discussion
    or decision-making process is reflected in the issue.
  • I have updated the documentation.
  • I have added tests around the new logic.

@github-actions github-actions bot added the UI UI specific issues label Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani chirag-madlani added the safe to test Add this label to run secure Github workflows on PRs label Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 51%
51.52% (25837/50148) 33.75% (10165/30120) 32.51% (2969/9132)

Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@harshach
Copy link
Collaborator

harshach commented Jan 5, 2024

hi @sandervanlaar thanks for the PR. We will review and merge it in

@harshach
Copy link
Collaborator

harshach commented Jan 7, 2024

Thanks @sandervanlaar for the awesome contribution!!

@harshach harshach merged commit 07e9c1a into open-metadata:main Jan 7, 2024
16 checks passed
@sandervanlaar sandervanlaar deleted the new_localization_nl branch January 17, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants