Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-14742: Adjusting metadata.py to filter by enum value #14884

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

marcorezende
Copy link
Contributor

@marcorezende marcorezende commented Jan 26, 2024

Describe your changes:

Its just a minimum change in the ingestion framework code to handle a bug that affects the ingestion of Airflow DAGs execution data to OpenMetadata

Fixes #14742

I worked on the change of value in the filter so that it is possible to perform the query because the query expects the string of value 'removed' and not the enum object removed

I tested carefully before the change, observing the behavior of the bug and after the change, confirming its resolution.

Type of change:

  • [X ] Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@marcorezende marcorezende requested a review from a team as a code owner January 26, 2024 01:17
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pmbrull pmbrull added the safe to test Add this label to run secure Github workflows on PRs label Jan 26, 2024
Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM

Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pmbrull pmbrull merged commit 37d9670 into open-metadata:main Jan 26, 2024
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When ingesting metadata from Airflow, execution data is not ingested.
2 participants