Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR : fix sidebar icon sizes and remove svg utils file #15058

Merged
merged 5 commits into from
Feb 8, 2024
Merged

MINOR : fix sidebar icon sizes and remove svg utils file #15058

merged 5 commits into from
Feb 8, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Feb 6, 2024 •
edited

Describe your changes:

  • fix sidebar icon sizes
  • fix navba and help dropdown icon sizes with spacing.
  • remove svg.utils file and used alternative ReactComponent icon where it's been used.
image image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Feb 6, 2024
@Ashish8689 Ashish8689 self-assigned this Feb 6, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024 •
edited

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 56%
 57.16% (29345/51342) 37.98% (11783/31024) 37.27% (3541/9502)

@Ashish8689 Ashish8689 added the e2e This will trigger e2e test workflows label Feb 7, 2024
@Ashish8689 Ashish8689 marked this pull request as ready for review February 7, 2024 10:47
@Ashish8689
Copy link
Contributor Author

@chirag-madlani changes made as per comments!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
0.0% Coverage on New Code
2.3% Duplication on New Code

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit a502581 into main Feb 8, 2024
18 of 20 checks passed
@Ashish8689 Ashish8689 deleted the icon-fixes branch February 8, 2024 05:27
Ashish8689 added a commit that referenced this pull request Feb 22, 2024
@Ashish8689
MINOR : fix sidebar icon sizes and remove svg utils file (#15058)
3ea82e0 
* fix sidebar icon sizes and remove svg utils file

* sonar fixes and icon color fixes

* fix icon size in navbar and in help dropdown

* change the name to kebab case

(cherry picked from commit a502581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

Assignees

@Ashish8689 Ashish8689

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ashish8689 @chirag-madlani @Sachin-chaurasiya