Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format cron from unix to quartz for internal apps , for others use unix #15070

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Feb 7, 2024

Describe your changes:

  • UI use Unix Syntax , format the internal App to expect the Unix Cron and convert it to Quartz internally.
  • For External App it will be directly passed since it will Unix Cron

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Feb 7, 2024
@mohityadav766 mohityadav766 requested a review from a team as a code owner February 7, 2024 09:22
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Feb 7, 2024
chirag-madlani
chirag-madlani previously approved these changes Feb 9, 2024
harshach
harshach previously approved these changes Feb 14, 2024
@mohityadav766 mohityadav766 merged commit 9fae19d into main Feb 14, 2024
15 checks passed
@mohityadav766 mohityadav766 deleted the useUnixCron branch February 14, 2024 14:29
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants