Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ui): cypress create uniq glossary for the tests #15073

Merged
merged 2 commits into from
Feb 8, 2024
Merged

test(ui): cypress create uniq glossary for the tests #15073

merged 2 commits into from
Feb 8, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes:

  • Improve uniq glossary names to avoid any conflict with other tests

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Feb 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 56%
 56.94% (29529/51862) 37.81% (11800/31212) 37.27% (3542/9504)

@chirag-madlani chirag-madlani added the e2e This will trigger e2e test workflows label Feb 7, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 1277b21 into main Feb 8, 2024
28 of 30 checks passed
@chirag-madlani chirag-madlani deleted the fix-glossary-cy branch February 8, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanh37 karanh37 karanh37 approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

Assignees
No one assigned
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chirag-madlani @karanh37 @Sachin-chaurasiya