Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update gx runtime batch #15078

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Feb 7, 2024

Describe your changes:

  • For runtime batch execution of GX we don't have any connection details, hence user need to provide db, schema, and table names -- e.g. running GX against a DF.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

@TeddyCr TeddyCr requested a review from a team as a code owner February 7, 2024 11:48
@github-actions github-actions bot added documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 7, 2024
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ayush-shah ayush-shah merged commit 11b82d4 into open-metadata:main Feb 7, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data quality documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants