Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add display name to request body (not overwrite value null) #15091

Conversation

Alexandr-Nedomets
Copy link
Contributor

Describe your changes:

Add display name to request body for Service dto(not overwrite value null)
Fixes
I don't have issue

displayName for service entity rewrite value to null.
how get bug:

  1. Edit service entity (fill field display name) and than save
  2. Click "connection" and then click "Edit connection" and than click "Save"
    After fix. Bug doesn't repeat
    Please merge change to branch 1.2.5-realese

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

github-actions bot commented Feb 8, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@Sachin-chaurasiya Sachin-chaurasiya added the safe to test Add this label to run secure Github workflows on PRs label Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 56%
56.41% (29251/51856) 37.64% (11750/31214) 36.81% (3498/9502)

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit 0410e65 into open-metadata:main Feb 8, 2024
20 of 26 checks passed
@Sachin-chaurasiya Sachin-chaurasiya mentioned this pull request Feb 9, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants