Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR - Add service information on Pipeline Status GET #15094

Merged
merged 3 commits into from
Feb 12, 2024
Merged

MINOR - Add service information on Pipeline Status GET #15094

merged 3 commits into from
Feb 12, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Feb 8, 2024

Describe your changes:

Related to https://github.com/open-metadata/openmetadata-collate/pull/311

We need to pass the service in the IngestionPipeline to add the right Argo Workflow labels in Collate

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull requested a review from a team as a code owner February 8, 2024 09:50
@pmbrull pmbrull added the safe to test Add this label to run secure Github workflows on PRs label Feb 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@pmbrull pmbrull merged commit e278515 into open-metadata:main Feb 12, 2024
14 checks passed
pmbrull added a commit that referenced this pull request Feb 12, 2024
@pmbrull @chirag-madlani
MINOR - Add service information on Pipeline Status GET (#15094)
2a0bce9 
* MINOR - Add service information on Pipeline Status GET

* Format

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OnkarVO7 OnkarVO7 OnkarVO7 approved these changes

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmbrull @OnkarVO7 @chirag-madlani