Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix \n on frontend in team description on Teams list page #15102

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

vitafon007
Copy link
Contributor

Describe your changes:

Fixes

I worked on the mapping with the openmetadata-ui/src/main/resources/ui/src/components/Team/TeamDetails/TeamHierarchy.tsx file, because the incorrect mapping of \n in the command description on the frontend didn't allow reliable information about the command.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

github-actions bot commented Feb 8, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani chirag-madlani added the safe to test Add this label to run secure Github workflows on PRs label Feb 8, 2024
@chirag-madlani
Copy link
Collaborator

Hi @vitafon007
Thanks for taking time and providing a fix, Can you also paste screenshot of your fix?
That will help us in fasting reviewing your changes

Copy link

github-actions bot commented Feb 8, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 58%
58.59% (30087/51352) 38.98% (12092/31018) 38.63% (3669/9497)

@vitafon007
Copy link
Contributor Author

vitafon007 commented Feb 8, 2024

Hi @vitafon007 Thanks for taking time and providing a fix, Can you also paste screenshot of your fix? That will help us in fasting reviewing your changes

@chirag-madlani , Hi!
Before:
image
After:
image
In edit description page
image

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit a4595e4 into open-metadata:main Feb 9, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants