Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR : fix UI issues #15110

Merged
merged 8 commits into from
Feb 9, 2024
Merged

MINOR : fix UI issues #15110

merged 8 commits into from
Feb 9, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Feb 8, 2024

Describe your changes:

Fixes

  • Fix Acivity Mention feed right panel, when no data is there and switch from other tabs
  • Fix settings page cards height.
  • Increase setting page card description font size.
  • fix loader to be in center for page load.
  • support markdown previewer in team hierarchy description.

Issue :

Screen.Recording.2024-02-09.at.12.16.58.AM.mov
image image

Resolved :

Screen.Recording.2024-02-09.at.12.16.27.AM.mov
image image image
Screen.Recording.2024-02-09.at.3.52.48.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Feb 8, 2024
@Ashish8689 Ashish8689 self-assigned this Feb 8, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 58%
59.07% (30302/51300) 39.28% (12179/31003) 39.01% (3701/9488)

@Ashish8689 Ashish8689 changed the title MINOR : fix mention feed right panel when no data is there MINOR : fix UI issues Feb 9, 2024
Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
2 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 6b770f4 into main Feb 9, 2024
16 of 18 checks passed
@chirag-madlani chirag-madlani deleted the activity-feed-right-panel-fix branch February 9, 2024 16:37
sushi30 pushed a commit to sushi30/OpenMetadata that referenced this pull request Feb 12, 2024
* fix mention feed right panel when no data is there

* support markdown parser in team table description column

* setting card height and description font size fix

* make initial and page loader in center

* remove margin from paragraph

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
karanh37 pushed a commit that referenced this pull request Feb 22, 2024
* fix mention feed right panel when no data is there

* support markdown parser in team table description column

* setting card height and description font size fix

* make initial and page loader in center

* remove margin from paragraph

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
(cherry picked from commit 6b770f4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants