Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Source Hash Issue #15126

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Fix Source Hash Issue #15126

merged 2 commits into from
Feb 12, 2024

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Feb 9, 2024 •
edited

Describe your changes:

Source Hash does not need to be part of setFields

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Feb 9, 2024
@mohityadav766 mohityadav766 requested a review from a team as a code owner February 9, 2024 13:21
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Feb 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 11, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@pmbrull pmbrull merged commit 1382145 into main Feb 12, 2024
14 checks passed
@pmbrull pmbrull deleted the fixSourceHashIssue branch February 12, 2024 05:44
mohityadav766 added a commit that referenced this pull request Feb 12, 2024
@mohityadav766
Fix Source Hash Issue (#15126)
497f9da 
* Fix Source Hash Issue

* Fix ClassificationResourceTest

(cherry picked from commit 1382145)
sushi30 pushed a commit to sushi30/OpenMetadata that referenced this pull request Feb 12, 2024
@mohityadav766 @sushi30
Fix Source Hash Issue (open-metadata#15126)
52f40fe 
* Fix Source Hash Issue

* Fix ClassificationResourceTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@OnkarVO7 OnkarVO7 Awaiting requested review from OnkarVO7

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mohityadav766 @pmbrull