Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test : added unit test for github star popup #15134

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Test : added unit test for github star popup #15134

merged 1 commit into from
Feb 12, 2024

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

  • added unit test for github star popup

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Feb 10, 2024
@Ashish8689 Ashish8689 self-assigned this Feb 10, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 10, 2024
@github-actions GitHub Actions
Copy link

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 59%
 60.1% (30830/51298) 39.81% (12346/31015) 39.76% (3772/9487)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 10, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya enabled auto-merge (squash) February 10, 2024 14:21
@Ashish8689 Ashish8689 enabled auto-merge (squash) February 10, 2024 18:52
@chirag-madlani chirag-madlani merged commit f6e5de3 into main Feb 12, 2024
19 checks passed
@chirag-madlani chirag-madlani deleted the github-star-unit-test branch February 12, 2024 06:05
sushi30 pushed a commit to sushi30/OpenMetadata that referenced this pull request Feb 12, 2024
@Ashish8689 @sushi30
added unit test for github star (open-metadata#15134)
9c2b40e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ashish8689 @chirag-madlani @Sachin-chaurasiya @ShaileshParmar11