Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Email Test Issues and Audit Log Issues #15183

Merged
merged 1 commit into from
Feb 14, 2024
Merged

[Fix] Email Test Issues and Audit Log Issues #15183

merged 1 commit into from
Feb 14, 2024

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Feb 14, 2024 •
edited

Describe your changes:

Fixes #14777 and #15135

  • Audit Logs Error are fixed in case the PUT calls are not returning entities
  • Added test Connection as part of Email Test
  • Made Email test call to be sync

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Feb 14, 2024
@mohityadav766 mohityadav766 requested a review from a team as a code owner February 14, 2024 15:46
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 14, 2024
@mohityadav766 mohityadav766 changed the title [Fix] Email Test Issues #15135 [Fix] Email Test Issues and Audit Log Issues Feb 14, 2024
@mohityadav766 mohityadav766 merged commit 20876fa into main Feb 14, 2024
14 checks passed
@mohityadav766 mohityadav766 deleted the fixTestEmailIssue branch February 14, 2024 15:52
@mohityadav766 mohityadav766 mentioned this pull request Feb 14, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@harshach harshach Awaiting requested review from harshach

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Audit Logs Throw Error Message with parsing failures
2 participants
@mohityadav766 @pmbrull