Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13985 - Azure KV Secrets Manager #15192

Merged
merged 8 commits into from
Feb 20, 2024
Merged

#13985 - Azure KV Secrets Manager #15192

merged 8 commits into from
Feb 20, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Feb 15, 2024

Describe your changes:

Fixes #13985

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added documentation Improvements or additions to documentation Ingestion backend devops safe to test Add this label to run secure Github workflows on PRs labels Feb 15, 2024
@github-actions GitHub Actions
Copy link

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

akash-jain-10
akash-jain-10 previously approved these changes Feb 15, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues

Measures
0 Security Hotspots
68.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pmbrull pmbrull requested a review from TeddyCr February 19, 2024 12:58
@pmbrull pmbrull merged commit 62c0cc7 into open-metadata:main Feb 20, 2024
28 checks passed
@pmbrull pmbrull deleted the issue-13985 branch February 20, 2024 06:18
pmbrull added a commit that referenced this pull request Feb 27, 2024
@pmbrull
#13985 - Azure KV Secrets Manager (#15192)
7e140ae 
* #13985 - Azure KV Secrets Manager

* Format

* #13985 - Azure KV Secrets Manager

* #13985 - Azure KV Secrets Manager

* Simplify credentials loading

* Simplify credentials loading

* Simplify credentials loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyCr TeddyCr TeddyCr approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@akash-jain-10 akash-jain-10 Awaiting requested review from akash-jain-10 akash-jain-10 is a code owner

Assignees
No one assigned
Labels
backend devops documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please Add Azure Key Vault as a supported Secrets Manager Implementation
3 participants
@pmbrull @TeddyCr @akash-jain-10