#15169 bug: Service password gets overwritten with '********' when editing connection details (any!)

[ShaileshParmar11]

Describe your changes:

#15169

Fixed bug: Service password gets overwritten with '********' when editing connection details (any!)

Screen.Recording.2024-02-15.at.4.54.32.PM.mov

Manually tested the below scenarios

1. Edit Config with wrong values and save, test connection should fail -> ✅
2. Edit Config with the right value and save, test connection should pass -> ✅
3. Re-run Ingestion after correct value -> ✅
4. Re-deploy should work after edit config -> ✅
5. After re-deploy, re-run ingestion -> ✅
6. API should not go for unchanged form save -> ✅
7. Verified changes for all the service -> ✅
8. Added wrong password while creating service, edited service with right creds -> ✅

Type of change:

• Bug fix
• Improvement
• New feature
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation

Checklist:

• I have read the CONTRIBUTING document.
• My PR title is Fixes <issue-number>: <short explanation>
• I have commented on my code, particularly in hard-to-understand areas.
• For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

[github-actions]

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	61.53% (31415/51056)	40.48% (12500/30876)	40.88% (3861/9444)

[harshach]

@ShaileshParmar11 @chirag-madlani we need to look all the services for this

[cypress]

2 failed tests on run #33182 ↗︎

2

709

12

0

0

Details:

Merge remote-tracking branch 'origin/main' into issue-15169
Project: openmetadata	Commit: 7cdf7b0e4b
Status: Failed	Duration: 37:23 💡
Started: Feb 17, 2024 5:49 AM	Ended: Feb 17, 2024 6:27 AM

  Pages/Users.spec.ts • 1 failed test • cypress-ci-psql-oss-7939644248-1

View Output Video

Test		Artifacts
User with different Roles > Update own admin details		Screenshots Video

  Flow/Explore.spec.js • 1 failed test • cypress-ci-psql-oss-7939644248-1

View Output Video

Test		Artifacts
Explore Page > should verify order of search results		Screenshots Video

Review all test suite changes for PR #15193 ↗︎

[ShaileshParmar11]

@ShaileshParmar11 @chirag-madlani we need to look all the services for this

Yes @harshach We have covered it for all the services, as we have a common component, changing one place will apply change to all the services.

[sonarcloud]

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud