MINOR: Improve Kafka Test Connection #15207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulixius9
requested review from
a team,
harshach,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
github-actions
bot
added
UI
harshach
reviewed
Feb 16, 2024
| @@ -60,6 +69,14 @@ def get_connection( | |||
| if connection.saslMechanism: | |||
| connection.consumerConfig["sasl.mechanism"] = connection.saslMechanism.value | |||
|
|
|||
| if ( | |||
| connection.consumerConfig.get("security.protocol") is None | |||
There was a problem hiding this comment.
is None is intended, let's say user has already provided the security.protocol in consumer config then that would be given precedence over the new field that has been added.
Jest test CoverageUI tests summary
|
|
|
pmbrull
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>